[PATCH] glx: Fix fbconfigs with no corresponding visual

Ian Romanick idr at freedesktop.org
Tue Apr 12 16:25:56 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/12/2011 12:12 PM, Adam Jackson wrote:
> On Tue, 2011-04-12 at 19:34 +0100, Jon TURNEY wrote:
> 
>> Would you consider combining this with the patch [1] I posted a while ago to
>> check that GLX_WINDOW_BIT is actually set in the fbConfig before we create a
>> visual
>>
>> [1] http://patchwork.freedesktop.org/patch/374/
> 
> I was confused for a moment by this comment, because I wasn't sure under
> what circumstances we'd ever create an fbconfig without GLX_WINDOW_BIT.
> The answer of course is for nested servers, where we simply mirror the
> host fbconfigs into our own.

And pbuffer-only fbconfigs.

> And yeah, that seems entirely sensible.  Thanks for the reminder.
> 
> - ajax
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk2k34QACgkQX1gOwKyEAw8opACeNDQuR4ap84Inw12T82t6aMHn
DRQAn2f4Dvl6YnXqsjlBs7Se2qQQN8OH
=Ttaw
-----END PGP SIGNATURE-----


More information about the xorg-devel mailing list