[PATCH 00/16] More static analysis fixes for Xlib

[Alan Coopersmith]

On 04/12/11 02:11 AM, conselvan2 at gmail.com wrote:
> 2011/3/30 Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>:
>> This series contains fixes for problems found in Xlib thought static
>> code analysis.
> 
> No one interested in reviewing this?

Hmm, I seem to have lost my copies - I thought I'd stuck them in my "xorg
patches to review/apply later" folder, but they're not there now, so I'm
working off the patchwork copies.

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
For these:

  [01/16] Fix memory leak with broken bitmap files in XReadBitmapFileData
  http://patchwork.freedesktop.org/patch/4759/

  [02/16] FSWrap: fix potential leak in copy_string_list
  http://patchwork.freedesktop.org/patch/4760/
  (Though it should only leak on platforms where malloc(0) doesn't return NULL,
   it was still wasting time getting to the point it returned NULL.)

  [03/16] Fix leaks in _XimEncodingNegotiation error paths.
  http://patchwork.freedesktop.org/patch/4758/
  (You don't actually need to check for null before calling Xfree(), but that
   was in the original code already.)

  [04/16] Fix memory leaks on _XimProtoCreateIC error paths
  http://patchwork.freedesktop.org/patch/4761/

  [05/16] Fix memory leak on _XimGetAttributeID error path
  http://patchwork.freedesktop.org/patch/4763/

  [06/16] Fix memory leaks on _XimWriteCachedDefaultTree error paths
  http://patchwork.freedesktop.org/patch/4770/

  [07/16] Fix memory leak on _XimCommitRecv error path
  http://patchwork.freedesktop.org/patch/4764/

  [08/16] Fix memory leaks on _XimCbDispatch error path
  http://patchwork.freedesktop.org/patch/4762/

  [09/16] om: Fix memory leak on read_EncodingInfo error path
  http://patchwork.freedesktop.org/patch/4765/

  [10/16] Fix memory leak on _XimGetAttributeID error path
  http://patchwork.freedesktop.org/patch/4768/
  (Could be squashed with patch 5, since it's the same bug in the same
   function, just replicated on a different line number.)

  [12/16] om: Fix potential memory leak in init_om
  http://patchwork.freedesktop.org/patch/4771/

  [15/16] xcms: Fix error on LINEAR_RGB_InitSCCData error path
  http://patchwork.freedesktop.org/patch/4767/

  [16/16] xcms: Fix memory leaks on LINEAR_RGB_InitSCCData error path.
  http://patchwork.freedesktop.org/patch/4769/

Not yet ready to call reviewed:

  [11/16] om: Fix memory leak on get_font_name error path
  http://patchwork.freedesktop.org/patch/4764/
  Don't you also need to free(pattern) on all the other return NULL
  calls in this function?   Perhaps a candidate for a goto, since
  the end of the function is Xfree(pattern); return rotate_font_ptr
  and rotate_font_ptr isn't allocated until after the last error
  check, so would still be NULL.

No longer valid:

  [13/16] Fix memory leak on XShrinkRegion error path
  http://patchwork.freedesktop.org/patch/4773/
  [14/16] Fix memory leak in XXorRegion error path
  http://patchwork.freedesktop.org/patch/4772/

  Already fixed in git master commit 993abe751f4141f54

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System