[PATCH] dix: Replace DEBUG_EVENTS + ErrorF with DebugF

[Peter Hutterer]

On Thu, Apr 14, 2011 at 10:47:54AM +0100, Daniel Stone wrote:
> Hi,
> 
> On Thu, Apr 14, 2011 at 05:36:11PM +1000, Peter Hutterer wrote:
> > @@ -1827,33 +1827,25 @@ TryClientEvents (ClientPtr client, DeviceIntPtr dev, xEvent *pEvents,
> >  {
> >      int type;
> >  
> > -#ifdef DEBUG_EVENTS
> > -    ErrorF("[dix] Event([%d, %d], mask=0x%lx), client=%d%s",
> > +    DebugF("[dix] Event([%d, %d], mask=0x%lx), client=%d%s",
> >             pEvents->u.u.type, pEvents->u.u.detail, mask,
> >             client ? client->index : -1,
> >             (client && client->clientGone) ? " (gone)" : "");
> > -#endif
> 
> Eep.  Maybe it's just because I'm the kind of weirdo that likes running
> with --enable-debug, but this would seriously grief everyone's sessions:
> that's the reason I never made the conversion myself.
> 
> Something like this would be nice:
> ./configure --enable-debug={all,general,events,randr,...}
> DebugF(DEBUG_EVENTS, "[dix] ...\n");
> 
> and then possibly a runtime switch so you can build with
> --enable-debug=all, and switch noisy events like that on with
> Xorg -debug +events,-randr
> 
> and co.
> 
> It's somewhere on my close-on-infinitely-long TODO list. :)

fair call. one day, one day...

Cheers,
  Peter