[PATCH 4/5] Xi: don't swap the status byte in the XIPassiveGrab replies

Daniel Stone daniel at fooishbar.org
Fri Apr 15 05:03:39 PDT 2011


On Fri, Apr 15, 2011 at 01:20:59PM +1000, Peter Hutterer wrote:
> Reported-by: Julien Cristau <jcristau at debian.org>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Reviewed-by: Daniel Stone <daniel at fooishbar.org>

One other thing I noticed here is the confusion between grab status
codes (e.g. testing against GrabSuccess) and Grab* actually returning
standard X error codes (rather than BadAccess instead of
AlreadyGrabbed).  I don't think we call out which is currently used in
the spec.  I have only dirty trees at the moment, but I've put it on my
TODO, along with checking that everyone actually uses the right set of
error codes.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110415/0a76dcd5/attachment.pgp>


More information about the xorg-devel mailing list