[PATCH] Move event filter initializer out of the structure itself

Jamey Sharp jamey at minilop.net
Fri Apr 22 23:10:04 PDT 2011


On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote:
> When kept in the structure, it causes the entire MAXDEVICES * 128 masks
> to be stored in the data segment and loaded from the file, and also leads
> to worries about later generations inheriting changes across server reset.

Seems sensible to me, and also seems like a correctness fix:

> -    /* The mask for pointer motion events may have changed in the last server
> -     * generation. See comment above definition of filters. */
> -    filters[0][PointerMotionMask] = MotionNotify;

This looks like it was backwards, before. If I'm not mistaken, this
array is supposed to be indexed by event numbers, and contain values
that are masks, right?

So this patch, deleting that broken assignment and simplifying the rest
of the code, strikes me as good all around.

Reviewed-by: Jamey Sharp <jamey at minilop.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110422/6322e0fe/attachment.pgp>


More information about the xorg-devel mailing list