[PATCH xts] tet: Ignore SIGWINCH (terminal window size change)

[Peter Hutterer]

On Fri, Aug 12, 2011 at 03:51:24PM -0700, Aaron Plattner wrote:
> This signal is asserted when the controlling terminal changes size,
> for example if you're running xts from an xterm and you resize the
> window.  This causes test tests to fail:
> 
>   70||"VSW5TESTSUITE CASE FillPoly 3"
>   10|34 /Xproto/pFillPoly 15:28:48|TC Start, scenario ref 71-0
>   15|34 3.3-lite 3|TCM Start
>   510|34|system 0: Abandoning testset: caught unexpected signal 28 (unknown signal)
>   80|34 1 15:28:49|TC End, scenario ref 71-0
> 
> These signals can't affect the test environment, so just ignore them
> all the time.
> 
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
> Tracking down test intermittency only to find that it's caused by me
> unconsciously rearranging my windows all the time gets really old really
> quickly.

Acked-by: Peter Hutterer <peter.hutterer at who-t.net>

do you actually run the test suite on your main box? I found it gives me a
lot of false positives and negatives alike - the WM screws up the
expectations.

Cheers,
  Peter

>  src/tet3/tcm/dtcm.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/src/tet3/tcm/dtcm.c b/src/tet3/tcm/dtcm.c
> index ecfc0a3..3d56e8d 100644
> --- a/src/tet3/tcm/dtcm.c
> +++ b/src/tet3/tcm/dtcm.c
> @@ -720,6 +720,14 @@ void	(*func)();
>  	{
>  		sig_init("TET_SIG_IGN", &sig_ign);
>  		sig_init("TET_SIG_LEAVE", &sig_leave);
> +#if defined(SIGWINCH)
> +		/*
> +		 * Ignore terminal window size changes, which don't affect the
> +		 * test environment.
> +		 */
> +		sigaddset(&sig_ign, SIGWINCH);
> +#endif
> +
>  		init_done = 1;
>  	}
>  
> -- 
> 1.7.4.1