[PATCH xts] tet: Ignore SIGWINCH (terminal window size change)

Dan Nicholson dbn.lists at gmail.com
Mon Aug 15 05:39:29 PDT 2011


On Fri, Aug 12, 2011 at 3:51 PM, Aaron Plattner <aplattner at nvidia.com> wrote:
> This signal is asserted when the controlling terminal changes size,
> for example if you're running xts from an xterm and you resize the
> window.  This causes test tests to fail:
>
>  70||"VSW5TESTSUITE CASE FillPoly 3"
>  10|34 /Xproto/pFillPoly 15:28:48|TC Start, scenario ref 71-0
>  15|34 3.3-lite 3|TCM Start
>  510|34|system 0: Abandoning testset: caught unexpected signal 28 (unknown signal)
>  80|34 1 15:28:49|TC End, scenario ref 71-0
>
> These signals can't affect the test environment, so just ignore them
> all the time.
>
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
> Tracking down test intermittency only to find that it's caused by me
> unconsciously rearranging my windows all the time gets really old really
> quickly.
>
>  src/tet3/tcm/dtcm.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/src/tet3/tcm/dtcm.c b/src/tet3/tcm/dtcm.c
> index ecfc0a3..3d56e8d 100644
> --- a/src/tet3/tcm/dtcm.c
> +++ b/src/tet3/tcm/dtcm.c
> @@ -720,6 +720,14 @@ void       (*func)();
>        {
>                sig_init("TET_SIG_IGN", &sig_ign);
>                sig_init("TET_SIG_LEAVE", &sig_leave);
> +#if defined(SIGWINCH)
> +               /*
> +                * Ignore terminal window size changes, which don't affect the
> +                * test environment.
> +                */
> +               sigaddset(&sig_ign, SIGWINCH);
> +#endif
> +
>                init_done = 1;
>        }
>

Hah, good catch.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list