[PATCH v2 2/4] input: make InputOption opaque, provide interface functions.

Dan Nicholson dbn.lists at gmail.com
Mon Aug 15 05:51:53 PDT 2011


On Sun, Aug 14, 2011 at 5:30 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> InputOptions is not switched to use struct list for a future patch to unify
> it with the XF86OptionRec.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - add required fixes for hal and dbus backends
> - expand testing to test key/value changes and insertion-overwrite
> - remove pointless error: label in input_option_new
> - use xf86AddNewOption in NIDR, it strdups for us

Looks good now. I'll try to review the rest of this series today, but
time is scarce. I really like the idea, though.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list