[PATCH 3/4] input: switch InputOption to use XF86OptionRec storage.

Dan Nicholson dbn.lists at gmail.com
Wed Aug 17 05:56:42 PDT 2011


On Wed, Aug 10, 2011 at 8:20 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> Use the same struct for both InputOption and XF86OptionRec so we don't need
> to convert to and fro the two in the config backends.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Now that I see this, I'm wondering why the generic structure isn't
called Option since it clearly isn't input configuration specific. It
would be really nice if we could just kill XF86OptionRec/Ptr, drop the
awkward GenericListRec, and use a generic Option with nt_list*
everywhere in the code. I realize this would break the xf86 API,
though. Maybe another day.

Anyway,

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list