[PATCH 2/8] Use correct swap{l,s} (or none at all for CARD8)

Peter Harris pharris at opentext.com
Wed Aug 17 07:25:18 PDT 2011


On 2011-08-16 22:58, Matt Turner wrote:
> Swapping the wrong size was never caught because swap{l,s} are macros.

> --- a/xkb/xkb.c
> +++ b/xkb/xkb.c
> @@ -6190,7 +6190,6 @@ char *			str;
>  	swaps(&rep.supported);
>  	swaps(&rep.unsupported);
>  	swaps(&rep.nDeviceLedFBs);
> -	swapl(&rep.type);
+	swaps(&rep.dfltKbdFB);
+	swaps(&rep.dfltLedFB);
+	swapl(&rep.devType);

Otherwise,
Reviewed-by: Peter Harris <pharris at opentext.com>

Thanks for fixing up swapping.

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866


More information about the xorg-devel mailing list