[PATCH synaptics] Adding support for OpenBSD

Peter Hutterer peter.hutterer at who-t.net
Tue Aug 23 16:57:02 PDT 2011


On Tue, Aug 23, 2011 at 09:34:58PM +0600, Alexandr Shadchin wrote:
> On Tue, Aug 23, 2011 at 01:20:10PM +1000, Peter Hutterer wrote:
> > > +static void
> > > +WSConsDeviceOnHook(InputInfoPtr pInfo, SynapticsParameters *para)
> > > +{
> > > +    int wsmouse_mode = WSMOUSE_NATIVE;
> > > +
> > > +    if (ioctl(pInfo->fd, WSMOUSEIO_SETMODE, &wsmouse_mode) == -1)
> > > +        xf86IDrvMsg(pInfo, X_ERROR, "cannot set native mode\n");
> > > +}
> > > +
> > > +static void
> > > +WSConsDeviceOffHook(InputInfoPtr pInfo)
> > > +{
> > > +    int wsmouse_mode = WSMOUSE_COMPAT;
> > > +
> > > +    if (ioctl(pInfo->fd, WSMOUSEIO_SETMODE, &wsmouse_mode) == -1)
> > > +        xf86IDrvMsg(pInfo, X_ERROR, "cannot set compat mode\n");
> > > +}
> > 
> > if these two are an error, we should change the On/Off hooks to return
> > boolean so we can bail out of the caller. that'd be a separate patch, at
> > least eventcomm.c needs it too.
> > 
> 
> Hmm, in http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/
> On/Off hooks is 'static void'. Maybe it's in your local repository?
> Could not you show this patch?

sorry, I meant this is an unrelated patch that should be done too. Quietly
failing in the device backends is not a good thing imo.

Cheers,
  Peter


More information about the xorg-devel mailing list