Alan Coopersmith alan.coopersmith at oracle.com
Fri Dec 2 11:32:31 PST 2011

On 12/02/11 03:31, Daniel Stone wrote:
> Remove _X_EXPORT tags from functions not used by any drivers.

> diff --git a/dix/dispatch.c b/dix/dispatch.c
> index 51b9033..bbf48db 100644
> --- a/dix/dispatch.c
> +++ b/dix/dispatch.c
> @@ -167,7 +167,7 @@ static int nextFreeClientID; /* always MIN free client ID */
>   static int	nClients;	/* number of authorized clients */
> -CallbackListPtr ClientStateCallback;
> +_X_EXPORT CallbackListPtr ClientStateCallback;

That looks like an add, not a remove.   Some reason for that?

> -extern _X_EXPORT FontPtr find_old_font(XID /*id*/);
> +extern FontPtr find_old_font(XID /*id*/);

libXfont appears to try to link with that one (though it has a weak linked stub
to fallback on so you may not notice right away, especially if you're not using
the font server).

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list