[PATCH] Include client name if available in PrintDeviceGrabInfo

Alan Coopersmith alan.coopersmith at oracle.com
Thu Dec 8 21:38:32 PST 2011

On 12/08/11 01:28, Rami Ylimäki wrote:
> Reviewed-by: Rami Ylimäki <rami.ylimaki at vincit.fi>


>> [3581736.601] Active grab 0x1600000 (core) on device 'Virtual core pointer' (2):
>> [3581736.601] client pid 26741 /usr/bin/xscreensaver -nosplash
>> + ErrorF(" (no client information available for client %d)\n",
>> + CLIENT_ID(grab->resource));
> I'd prefer the format to be %lx as that is used generally for resources. That
> would make it easier to find the client XID from output of xrestop for example.

Is that necessary when we already print the grab resource id on the previous
line?  People who want that format can just ignore the trailing bits of the
resource id.

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list