[PATCH xserver 1/4] Replace deprecated CWARNFLAGS with BASE_CFLAGS and NO_STRICT_ALIASING_CFLAG

Alan Coopersmith alan.coopersmith at oracle.com
Fri Dec 9 20:06:58 PST 2011

On 12/09/11 15:10, Keith Packard wrote:
> On Fri, 09 Dec 2011 13:33:17 -0500, Gaetan Nadon<memsize at videotron.ca>  wrote:
>> Thanks for checking, it's the first time we use these new 1.16 macros.
> Wow. Those are sure chatty. Are you sure we want all of these new
> warnings? -Winline doesn't seem useful to me. Also a lot of noise from
> -Wredundant-decls and -Wshadow.

Now you can see why you've gotten so many warning cleanup patches since
Jeremy added the additional flags to the defaults and some of us pulled
the git master and started building with them.

I agree that -Winline doesn't seem that useful unless you're in the middle
of doing performance tuning and needing that level of detail - mostly it
seems to tell me that gcc doesn't support inlining vararg functions like
those xtrans uses for printing debug messages.

The Xserver is particularly noisy for -Wredundant-decls - some cleanup
of the input & device headers could probably help a lot there.

Mark also pointed out in another review that the gcc developers have agreed
to trim some of the warnings from -Wshadow in future to reduce some of the
less useful noise there:

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list