[PATCH xserver 1/4] Replace deprecated CWARNFLAGS with BASE_CFLAGS and NO_STRICT_ALIASING_CFLAG

[Alan Coopersmith]

On 12/10/11 10:13, Jeremy Huddleston wrote:
> Re: -Winline specifically since you brought it up.  If the intent is to make an inline function for performance reasons, and that function actually can't be inlined, I'd think we'd want to know.  Specifically regarding xtrans, perhaps we should just make those vararg functions !inline.

Except that it only tells you that it can't be inlined by that particular
compiler on that platform - not that a different gcc version couldn't do
it, or a different compiler (clang, Solaris Studio, Intel, etc.) couldn't.

Also, some of the warnings it generates in the Xserver are simply "optimizer
decided it was unprofitable to inline at this particular call site", not
"you designed this function in a way the optimizer can never inline it
anywhere".

As I said, if you're doing specific performance tuning, I can see turning it
on, but in general builds it seems more like noise drowning out more useful
warning messages.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System