[PATCH 0/4] Move GC clip management to ScreenRec

Jamey Sharp jamey at minilop.net
Wed Dec 14 15:57:05 PST 2011

Could you have a look at my patches to do this, from October? I believe
Keith just wanted an ABI bump before merge, but I'd run out of time by
then, and now I assume it's too late for this cycle.

They're still sitting on my "reviewed" branch:


Here's part of the discussion thread:



On Mon, Dec 05, 2011 at 01:56:13PM -0500, Adam Jackson wrote:
> None of the GC wrappers do anything particularly interesting with clip
> management.  I think in theory this was meant to allow the driver to
> flatten the clip to a bitmap and/or keep track of a window ID, but the
> only example I can find of anything remotely like that in open code is
> Xprint's PostScript backend, which, well.
> I've not tested this in any real sense.  It would want at least an xts5
> run against Xnest and Xvfb before committing.  The CopyClip change might
> want to be a screen func as well for symmetry.
> Longer term I don't think there's any reason to have GCFuncs at all, and
> that the whole thing could be embedded in the ScreenRec.
> Dead code diff:
>    text	   data	    bss	    dec	    hex	filename
> 1844275	  52216	  64384	1960875	 1debab	Xorg-clip-gc
> 1842034	  52120	  64384	1958538	 1de28a	Xorg-clip-screen
> - ajax
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111214/b8ce4931/attachment.pgp>

More information about the xorg-devel mailing list