[PATCH util-macros 1/1] Turn on the selective -Werror=... CFLAGS for development builds only

Daniel Stone daniel at fooishbar.org
Mon Dec 19 15:10:18 PST 2011


On 19 December 2011 18:31, Jeremy Huddleston <jeremyhu at apple.com> wrote:
> The util-macro changes added just a handful of select errors (like implicit) to catch these types of bad bugs.  I want them to be on for everyone because they will catch bugs.  I'm sorry that I hadn't tested kdrive on linux before shipping, but the tinderbox has been updated to build that case now, but I don't think that's a reason to disable them.
> Would people prefer the --disable-selectve-werror option to turn them off if needed?  That's the other option that will allow users to easily get past it (and hopefully prompt a bug report if they run into issues).

It all sounds reasonable, but breaking compilation when the toolchain
gets updated is seriously, seriously obnoxious.  It will happen, and
our users will hate us.

I'm all for picking this up in the development cycle though, so
perhaps we could enable werror by default in development builds, and
then flip the default back to disabled around RC1 and leave it like
that for stable series? That seems like it achieves both goals of
forcing developers to see and fix errors, and not having our users all
hate us.


More information about the xorg-devel mailing list