[Resend: PATCH v2] Add Solaris support to DetermineClientCmd

Rami Ylimäki rami.ylimaki at vincit.fi
Wed Dec 21 00:49:07 PST 2011

On 12/20/2011 11:15 PM, Alan Coopersmith wrote:
> Uses /proc/pid/psinfo to read command & partial arguments.

Based on the comments in the code, reading from that file looks OK. I'm 
not otherwise familiar with this interface.

> Moves cmdsize & argsize variables into non-Solaris #else clause
> to avoid unused variable warnings.

Seems OK.

> Fixes format mismatch errors when building with DEBUG defined on
> a 64-bit platform (where Mask is defined as CARD32).

Looks fine as well.

> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Reviewed-by: Rami Ylimäki <rami.ylimaki at vincit.fi>

More information about the xorg-devel mailing list