[PATCH xrandr-utils 4/6] Add unit test suite and a basic test of the geometry structs.

Bryce Harrington bryce at canonical.com
Thu Dec 22 17:46:48 PST 2011


On Thu, Dec 22, 2011 at 07:47:38PM -0500, Gaetan Nadon wrote:
> On 11-12-21 09:47 PM, Bryce Harrington wrote:
> >+static void geometry_rectangle(void)
> >+{
> >+    XRURectangle r;
> 
> The 'make check' target fails which causes 'make distcheck' to fail.
> 
> geometry.c: In function ‘geometry_rectangle’:
> geometry.c:66:5: error: unknown type name ‘XRURectangle’
> 
> I could not find this defined anywhere.
> The module configures ok, so I assume all dependencies are met.

Right, I had noticed that XRURectangle was redundant with XRUBox, and
that the original xrandr.c code does not use the structure anywhere, so
dropped it, but guess I forgot to drop the test.  (Or run the tests
after making the change apparently!)

Thanks, fixed up the patches, will repost the set.

Bryce


More information about the xorg-devel mailing list