[PATCH 01/11] glx: Fix mishandling of shared contexts

Eric Anholt eric at anholt.net
Sat Dec 24 15:35:25 PST 2011


On Fri, 23 Dec 2011 15:18:19 -0800, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  glx/glxcmds.c |   22 +++++++++++-----------
>  1 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/glx/glxcmds.c b/glx/glxcmds.c
> index d5b764f..c5de60d 100644

> +	/* Page 26 (page 32 of the PDF) of the GLX 1.4 spec says:
> +	 *
> +	 *     "The server context state for all sharing contexts must exist
> +	 *     in a single address space or a BadMatch error is generated."
> +	 *
> +	 * If the share context is indirect, force the new context to also be
> +	 * indirect.  If the shard context is direct but the new context

"shared".

Other than that, I'm assuming that checking for address space matches
between two direct contexts is handled by the client side (I think I
recall code to that effect, and seems like the only possible place),
which would make this:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20111224/1e13b849/attachment.pgp>


More information about the xorg-devel mailing list