[PATCH v2 18/25] [libx11] Initialize local variable

Alan Coopersmith alan.coopersmith at oracle.com
Tue Feb 1 00:12:09 PST 2011


On 01/31/11 04:02 AM, Erkki Seppälä wrote:
> Using uninitialized value "error.resourceID" in call to function "_XError"
> 
> Reviewed-by: Erkki Seppälä <erkki.seppala at vincit.fi>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
> Signed-off-by: Erkki Seppälä <erkki.seppala at vincit.fi>
> ---
>  src/GetProp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/GetProp.c b/src/GetProp.c
> index a80c19c..5d6e0b8 100644
> --- a/src/GetProp.c
> +++ b/src/GetProp.c
> @@ -46,7 +46,7 @@ XGetWindowProperty(
>  {
>      xGetPropertyReply reply;
>      register xGetPropertyReq *req;
> -    xError error;
> +    xError error = {0};
>  
>      LockDisplay(dpy);
>      GetReq (GetProperty, req);

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list