[PATCH] glx: Refcnt the GLXDrawable to avoid use after free with multiple FreeResource

[Chris Wilson]

On Thu, 16 Dec 2010 15:55:42 +0100, Michel Dänzer <michel at daenzer.net> wrote:
> [ Dropping dri-devel list as this seems strictly an xserver issue ]
> 
> On Fre, 2010-12-10 at 14:49 +0100, Michel Dänzer wrote: 
> > On Fre, 2010-12-10 at 13:38 +0000, Chris Wilson wrote: 
> > > Although there may be more than one resource handles pointing to the
> > > Drawable, we only want to destroy it once and only reference the
> > > resource which may have just been deleted on the first instance.
> > > 
> > > v2: Apply fixes and combine with another bug fix from Michel Dänzer,
> > >     https://bugs.freedesktop.org/show_bug.cgi?id=28181
> > > 
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: Kristian Høgsberg <krh at bitplanet.net>
> > > Cc: Michel Dänzer <daenzer at vmware.com>
> > 
> > Reviewed-by: Michel Dänzer <michel at daenzer.net>
> > 
> > I'd wait for Kristian's review as well though.
> 
> Any take on this, Kristian?

Kristian, poke. This patch gets X working again with GL and
modeswitching. If you still want to you can do a code removal patch later
and gain hero points... :)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre