[Patch] refactor pointer acceleration

Simon Thum simon.thum at gmx.de
Sun Feb 6 05:15:55 PST 2011


On 02/06/2011 10:18 AM, walter harms wrote:
> hi Simon,
> thx for you effort, just one thing:
> you will get more feedback when you send the patches one by one
> in the body and not as attachment.
Well, I admit sticking to the workflow easiest for me, since my mailer
just inlines text attachments so it doesn't impair me when others do
that. I'll see if I can make Thunderbird and git friends somehow.

Cheers,

Simon

> 
> re,
>  wh
> 
> Am 05.02.2011 22:39, schrieb Simon Thum:
>> Hi Peter,
>>
>> the patch series consists mainly of refactoring, no functional changes.
>> The main point is to separate property handling from the acceleration
>> structure and to make use of the ValuatorMask struct now in place.
>>
>> They work on my machine, any I don't think much further testing is required.
>>
>> And one more thing: The some code in AddInputDevice seems bogus to me,
>> but I don't have the HW to test it. The transform matrix gets set as a
>> input property before the handler is registered. Thus if I'm right,
>> dev->transform never gets initialized as long as no-one updates the
>> property. Simply moving the handler registration upwards should fix it.
>>
> 



More information about the xorg-devel mailing list