[PATCH 5/8] Return BadMatch if a Port Attribute is not found
Mauro Carvalho Chehab
mchehab at redhat.com
Fri Feb 11 07:54:21 PST 2011
Fix a small non-compliance issue: if a port attribute is not known,
according with Xv specs, it should return BadMatch, and not BadValue.
Signed-off-by: Mauro Carvalho Chehab <mchehab at redhat.com>
diff --git a/src/v4l.c b/src/v4l.c
index 8b3d87e..fbb8bd7 100644
--- a/src/v4l.c
+++ b/src/v4l.c
@@ -790,6 +790,8 @@ V4lSetPortAttribute(ScrnInfoPtr pScrn,
/* not mine -> pass to yuv scaler driver */
if (0 != pPPriv->yuv_format && pPPriv->myfmt->setAttribute)
ret = pPPriv->myfmt->setAttribute(pScrn, attribute, value);
+ else
+ ret = BadMatch;
goto err;
}
if (pPPriv->XvV4LCtrl[i].qctrl.flags & V4L2_CTRL_FLAG_DISABLED)
@@ -839,6 +841,8 @@ V4lGetPortAttribute(ScrnInfoPtr pScrn,
/* not mine -> pass to yuv scaler driver */
if (0 != pPPriv->yuv_format && pPPriv->myfmt->getAttribute)
ret = pPPriv->myfmt->getAttribute(pScrn, attribute, value);
+ else
+ ret = BadMatch;
goto err;
}
if (pPPriv->XvV4LCtrl[i].qctrl.flags & V4L2_CTRL_FLAG_DISABLED)
--
1.7.1
More information about the xorg-devel
mailing list