[PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

[Alan Coopersmith]

On 02/19/11 08:51 AM, Fernando Tarlá Cardoso Lemos wrote:
> Some references:
> 
> http://wiki.debian.org/ToolChain/DSOLinking
> https://fedoraproject.org/wiki/UnderstandingDSOLinkChange

Neither of those explain what "FTBFS" means.   (They mostly seem to explain
that Linux is catching up to the linking requirements we've had on Solaris
for years, which sounds good to me.)

> +
> +# Function dl() comes from the C library or -ldl
> +AC_SEARCH_LIBS([dlopen], [dl])

This seems to duplicate the checks we already have via AC_LIBTOOL_DLOPEN.
Those only went into git a couple months ago, and haven't been released
yet:
http://cgit.freedesktop.org/xorg/app/xdm/commit/?id=50c96170ad42321310c346cf412f9ae7e80ec2a7

>  # Checks for header files.
> @@ -287,7 +290,7 @@ AC_SUBST(SHELL_CMD)
>  
>  # Checks for pkg-config packages
>  
> -PKG_CHECK_MODULES(XDM, xmu x11 xau)
> +PKG_CHECK_MODULES(XDM, xmu x11 xau xext)

Why do you believe this is needed?   I see nothing in xdm that calls
functions in libXext.   The greeter library does, but that's already
covered in:
PKG_CHECK_MODULES(XDMGREET, xt x11 xext)

What error are you getting that this solves?

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System