[PATCH] Unbreak the .m.c rule

Peter Hutterer peter.hutterer at who-t.net
Wed Feb 23 14:06:48 PST 2011


On Wed, Feb 23, 2011 at 05:53:57AM -0800, Dan Nicholson wrote:
> On Tue, Feb 22, 2011 at 9:04 PM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
> > On Tue, Feb 22, 2011 at 05:57:26PM -0500, Adam Jackson wrote:
> >> Some builds of gnu make apparently know how to go straight from .m to .o.
> >> That's great if your .m file is Objective C source, but for us, it's not.
> >>
> >> Signed-off-by: Adam Jackson <ajax at redhat.com>
> >> ---
> >>  xts5/common.mk |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/xts5/common.mk b/xts5/common.mk
> >> index 52d0fd6..d36c25e 100644
> >> --- a/xts5/common.mk
> >> +++ b/xts5/common.mk
> >> @@ -10,6 +10,10 @@ MC = $(top_builddir)/xts5/src/bin/mc/mc
> >>  AM_V_MC = $(am__v_MC_$(V))
> >>  am__v_MC_ = $(am__v_MC_$(AM_DEFAULT_VERBOSITY))
> >>  am__v_MC_0 = @echo "  MC    " $@;
> >> +
> >> +# empty rules to turn off objc magic.  grr.
> >> +%.o : %.m
> >> +
> >>  .m.c:
> >>       $(AM_V_MC)TET_ROOT='$(abs_top_srcdir)' $(MC) -o $@ $<
> >>  .m_m.c:
> >> --
> >> 1.7.4.1
> >
> > Acked-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Peter, did we discuss some other way to fix this? Either way, this
> looks like the right thing to do.

yeah, we did. I just renamed all of them to .mc :)
patch has been sitting in my tree for ages, together with about 20 other
onces. Need to dig them up again but at least for the renaming one, there's
no reason now.
 
Cheers,
  Peter


More information about the xorg-devel mailing list