[PATCH 00/11] Allow registering only wakeup or block handler

Mark Kettenis mark.kettenis at xs4all.nl
Tue Jan 4 03:26:25 PST 2011

> From: Pauli <ext-pauli.nieminen at nokia.com>
> Date: Fri, 31 Dec 2010 19:30:58 +0200
> From: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> Here is improved version of removing random empty block and wakeup
> handlers.  First patch breaks the current handler code and extens
> API. That patch is most likely to cause problems. Too bad
> refactoring is hard to split to smaller patches.

Not sure what you mean by "most likely to cause problems"; you're
keeping the old interface and don't really change how it works, so you
should be fine here.

And to be honest, I don't see the point of splitting up in tons of
tiny micropatches.

> I hope Mark likes this patch set more than previous try to eliminate extra
> functions.

Yes, introducing seperate functions is better than making
RegisterBlockAndWakeupHandlers() accept NULL arguments, which would be
an ABI break.

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

More information about the xorg-devel mailing list