[PATCH v3 5/7] composite: Add SourceValidate wrapper

Ville Syrjälä ville.syrjala at nokia.com
Tue Jan 4 10:32:49 PST 2011

On Tue, Jan 04, 2011 at 05:55:51PM +0200, ville.syrjala at nokia.com wrote:
> From: Ville Syrjälä <ville.syrjala at nokia.com>
> When SourceValidate is performed on a window with IncludeInferiors
> sub-window mode, force an immediate update of all the automatically
> redirected windows, so that the current window contents will be up
> to date.

BTW I just realized that this patch won't work properly without the
damagedDescendants patch.

The problem is that compReportDamage marks the window as damaged before
SourceValidate is called during ProcCopyArea. compScreenUpdate would
then update the whole tree, before the CopyArea actually happens.

It looks like it can be fixed easily with DamageSetReportAfterOp.
Assuming we want to make the code work correctly without the
damagedDescendants patch. 

AFAICS changing to "report after" damage shouldn't cause any problems
even with the damagedDescendants patch, although it doesn't really
need it, since it would only update the subtree that isn't damaged by

Ville Syrjälä

More information about the xorg-devel mailing list