[PATCH keyboard] Small cleanup.

Alexandr Shadchin alexandr.shadchin at gmail.com
Tue Jan 4 21:16:52 PST 2011


On Wed, Jan 5, 2011 at 2:00 AM, Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
> On 01/ 4/11 11:55 AM, Alexandr Shadchin wrote:
>> On Tue, Nov 30, 2010 at 08:33:31PM +0100, Mikhail Gusarov wrote:
>>>
>>> Twas brillig at 15:36:36 30.11.2010 UTC+05 when alexandr.shadchin at gmail.com did gyre and gimble:
>>>
>>>  AS> Removed unnecessary code:
>>>  AS>         case PCCONS:
>>>  AS>                 break;
>>>
>>> Reviewed-by: Mikhail Gusarov <dottedmag at dottedmag.net>
>>>
>>> --
>>>   http://fossarchy.blogspot.com/
>>
>> Somebody push? Thanks in advance.
>
> I don't seem to still have a copy of the original, since I deleted
> keyboard patches from my todo folder the other day that looked like they
> matched commits that had been pushed.
>
> It really helps if you use more descriptive and unique patch titles -
> "small cleanup" doesn't help anyone looking in the changelog nor
> maintainers looking to see what's been pushed or not.
>
> An excellent suggestion on what to put in commit titles and comments is
> at http://who-t.blogspot.com/2009/12/on-commit-messages.html
>

I'm sorry, I have bad English, it is not my laziness to write good commit
messages. In the future I will write in greater detail (at least try).
Thanks for link.

> --
>        -Alan Coopersmith-        alan.coopersmith at oracle.com
>         Oracle Solaris Platform Engineering: X Window System
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>

-- 
Alexandr Shadchin


More information about the xorg-devel mailing list