[PATCH v4 6/7] composite: Use DamageSetReportAfterOp

Keith Packard keithp at keithp.com
Wed Jan 5 08:34:12 PST 2011

On Wed,  5 Jan 2011 15:51:36 +0200, ville.syrjala at nokia.com wrote:
> From: Ville Syrjälä <ville.syrjala at nokia.com>
> Use the "report after" damage mode for marking the automatically
> redirected as damaged. Avoids a premature window tree update triggered
> by compSourceValidate eg. during a CopyArea request. If the window is
> marked as damaged before the CopyArea has actaully happened, the window
> tree update will copy stale data to the parent.

I didn't comment on this one before because I didn't understand what it
was doing. I think I've got it now -- the window damage gets registered
in the Damage CopyArea wrapper, then SourceValidate is called which
copies the window contents to its parent, then the data are copied. At
this point, the window has no damage recorded and yet there are changed

Given that the hierarchical composite damage fixes this problem in a
cleaner fashion, should we just use that patch and not this one?

Yeah, I know I said it was "just an optimization", but I think you've
discovered that it isn't just an optimization...

keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110105/68f55b97/attachment.pgp>

More information about the xorg-devel mailing list