[PATCH 4/5] resource: Remove expectID hack

Daniel Stone daniel at fooishbar.org
Mon Jan 10 07:03:59 PST 2011

On Fri, Jan 07, 2011 at 02:27:28PM -0500, Adam Jackson wrote:
> This is clearly meant to short-circuit the (modestly) expensive resource
> lookup in LegalNewID.  The problem is that long-lived clients will
> eventually run completely through their XID space and start asking
> XC-MISC for IDs to reuse.  Once that happens, the comparison against
> expectID will always be true, and we'll no longer catch XID collisions
> at all.
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Reviewed-by: Daniel Stone <daniel at fooishbar.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110110/0f44ad38/attachment.pgp>

More information about the xorg-devel mailing list