[PATCH xinput xi2.1] Ensure that the parent always accepts or rejects a touch
peter.hutterer at who-t.net
Mon Jan 10 14:48:34 PST 2011
On Mon, 10 Jan 2011 17:58:52 +0000, Daniel Stone <daniel at fooishbar.org> wrote:
> On Mon, Jan 10, 2011 at 11:51:12AM -0600, Chase Douglas wrote:
> > On 01/10/2011 09:08 AM, Daniel Stone wrote:
> > > On Fri, Jan 07, 2011 at 01:06:04PM -0500, Chase Douglas wrote:
> > >> If a touch ends before the 5 motion events have occurred, the parent
> > >> window must also accept or reject the touch. Otherwise, the touch will
> > >> be left dangling.
> > >>
> > >> I also added a printout stating whether the client accepted or rejected
> > >> the touch.
> > >
> > > Thanks, but this is only useful for multitouch dev: I'm going to remove
> > > it before I merge it into mainline.
> > Yep, I just wanted to be sure we were testing things correctly during
> > development :).
> > Would it make sense to keep the code around and use an argument to
> > test-xi2 so the testcase can always be used even after release?
> Yeah, I think it'd be useful to keep around in some form, though not by
> default. Peter?
xinput --test-xi2 was supposed to be the xi2 equiv of --test (which
simply prints device coordinates). I realise that I've pushed it a bit
further than that and it should be restored to just that
behaviour. Hence, I'd rather not have any developer-specific cases in
it might be interesting however to have a --developer-tests (or
something with a better name)? or should we put this somewhere else?
More information about the xorg-devel