[PATCH 0/4] xv: Fix auto key color fill with reput image & code clean up

Pauli Nieminen ext-pauli.nieminen at nokia.com
Fri Jan 14 08:24:57 PST 2011

On 14/01/11 15:44 +0200, Pauli wrote:
> From: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
> Following patches were created while I was fixing incorrect order of auto color
> key filling and window background painting in window resize.
> Problem was that reput image would fill color key in reput but window background
> painting only happens in WindowExposures hook. WindowExposures would be good
> place to call reput after background painting but it isn't called for every clip
> change.
> Then I decided that it would be simpler to only use ClipNotify hook to mark
> ports that require reput. Reput is then actually done in PostValidateTree
> hook. 
> Pauli Nieminen (4):
>   xf86/xv: Remove copy paste code.
>   xf86/xv: Remove unused GC pointers
>   xf86/xv: Use PostValidateTree to do reput
>   xf86/xv: Only register PostValidateTree hook when there is work to do
>  hw/xfree86/common/xf86xv.c     |  149 ++++++++++------------------------------
>  hw/xfree86/common/xf86xvpriv.h |    5 +-
>  2 files changed, 38 insertions(+), 116 deletions(-)

This won't work correctly for all cases. We had face to face chat with Ville
about problems if clipboxes are staying same and how exposures should affect

I'm cooking improved patch set to fix the corner cases.

More information about the xorg-devel mailing list