[PATCH] xkb: after making changes to the xkb ctrls, copy them back into kbdfeed.

Daniel Stone daniel at fooishbar.org
Wed Jan 19 18:14:23 PST 2011


On Thu, Jan 13, 2011 at 01:45:02PM +1000, Peter Hutterer wrote:
> enabled_ctrls_changes is nowhere near the usual event or config paths. So
> this condition always evaluated to false and the memcpy would thus never
> been hit. As a result, any modification to the XKB struct during
> XkbUpdateDescActions was not reflected in the kbdfeed ctrls.
> The flag that is set by XkbUpdateDescActions() if ctrls were changed are in
> enabled_ctrls.

Hm.  EnableDisableControls does affect enabled_ctrls_changes, but
cunningly, it only sees fit to call XkbUpdateIndicators when it's done.
So it could in theory toggle global autorepeat state when a client
vanishes (because that's the only caller), and no-one would realise
until something else caused it to be kicked.  Nice one.

So, on the grounds that this almost certainly doesn't make anything
worse, and the client-gone path needed fixing anyway (please file a
Reviewed-and-regretted-by: Daniel Stone <daniel at fooishbar.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110120/86cf136d/attachment.pgp>

More information about the xorg-devel mailing list