[PATCH (v5) 0/15] Multitouch take five

Cyril Brulebois kibi at debian.org
Sun Jan 23 17:34:26 PST 2011

Daniel Stone <daniel at fooishbar.org> (19/01/2011):
> Another round of multitouch patches ... this lot addresses all the
> review comments from the previous patchset, and seems to work quite
> reliably and consistently for me.  It's a fairly large change, but the
> code is now a fair bit easier to understand and verify.

So I played a bit with those patches and here's the extra comments I've
 * server side: make && make check are OK for */8 except for 7/8 (then
   8/8), due to the wrong parameter count I mentioned earlier. I “fixed”
   it locally by only passing the first two, which seemed to do the job.
   With that change, the only failing “make check” was with 7/8:
   | /xi2/protocol/XISelectEvents: **
   | ERROR:protocol-xiselectevents.c:110:request_XISelectEvent: assertion failed: (rc == error)
   | /bin/sh: line 5: 21379 Aborted                 ${dir}$tst
   | FAIL: protocol-xiselectevents
 * driver side: your patches led to a segfaulting X, after a few events
   from my non-multitouch-enabled touchpad, in valuator_mask_copy().
   I mentioned it on IRC, and Chase pointed me to his v2 of the evdev
   patch, which gave me an apparently functional X again.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110124/998415e5/attachment.pgp>

More information about the xorg-devel mailing list