[PATCH 28/32] [libx11] Comparing array against NULL is not useful "&xkb->server->vmods != NULL"

Alan Coopersmith alan.coopersmith at oracle.com
Thu Jan 27 07:54:46 PST 2011

On 01/27/11 01:50 AM, walter harms wrote:
>> diff --git a/src/xkb/XKBMisc.c b/src/xkb/XKBMisc.c
>> index fc5ae5f..4aa1f73 100644
>> --- a/src/xkb/XKBMisc.c
> I am not an expert on X11 coding style: 

It's XKB - the style doesn't match the rest of X11, nor anything you ever want
to see again.   Cleaning that mess up is a definite rainy day project for
someone.   (Daniel & Peter have cleaned the server side up a bit already.)

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list