[PATCH RESEND app-rstart 00/15] Review configuration

Alan Coopersmith alan.coopersmith at oracle.com
Thu Jan 27 21:59:49 PST 2011

On 01/27/11 12:58 PM, Gaetan Nadon wrote:
> Replace cpp/sed combination with sed only for simple text substitution.
> A number of substitutions were not required as the values are hard coded
> in the makefile and have not changed for the last decade.
> Replace the huge install FIXME shell code with proper Automake code.
> Perform target separation in appropriate subdirs which greatly
> simplifies Makefiles
> Gaetan Nadon (15):
>   config: use a single directory variable to represent $lib/X11/rstart
>   config: -DSERVERNAME not required in client.cc and server.cpp
>   config: -DBINDIR not required in server.cpp
>   config: use sed rather than cpp to substitute directory values
>   config: use sed rather than cpp to substitute rsh command value
>   config: use sed rather than cpp to substitute config values
>   config: -DPACKAGEname and -DENVPREFIX not required in config.in
>   config: install commands using Automake
>   config: install contexts files using Automake
>   config: let the samples directory handle the samples
>   config: let the specs directory handle the specs files
>   config: add links from x and x11 from @Aliases
>   config: move scripts into their own directory
>   config: rstartd.real does not require linking to any library
>   config: upgrade configure.ac

I'm not sure it was worth all that effort given how little used rstart is,
but since the effort is already spent, might as well commit it.

For the series:
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list