[PATCH x11perf] Make sure that window fits into screen.

Rami Ylimäki rami.ylimaki at vincit.fi
Fri Jan 28 06:03:09 PST 2011

On 01/28/2011 03:14 PM, walter harms wrote:
> Am 28.01.2011 13:59, schrieb Michel Dänzer:
>> On Fre, 2011-01-28 at 13:10 +0200, Rami Ylimäki wrote:
>>> XGetImage request will correctly fail and terminate x11perf with a
>>> BadMatch error if window is larger than its backing pixmap.
>>> This change makes all tests from putimage10 to getimagexy500 work on
>>> screens that are smaller than the default window size.
>> The numbers are not comparable if the operation dimensions are
>> different. It might be better to refuse tests that can't fit.
> but the idea i correct. May be an extra test ?
> On the other side: what is the time difference ?
> re,
>   wh

For example, compwinwin500 was 80% faster with reduced window size.

How about refusing the tests by default to make them comparable, but 
introducing -width, -height, and -redirect options for those who still 
want to run all tests? The extra options would print to the output to 
make it clear that nonstandard options are used.

-- Rami

More information about the xorg-devel mailing list