[PATCH libxkbcommon] Check for x11 as well through pkg-config.

[Gaetan Nadon]

On Sat, 2011-01-29 at 03:31 +0100, Cyril Brulebois wrote:

> Otherwise, ./configure returns successfully while xkbparse.lo can fail
> to build due to a missing include:
> |   YACC   xkbparse.c
> |   CC     xkbparse.lo
> | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 0026441..d8db8fd 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -66,7 +66,7 @@ if test "x$CC_FOR_BUILD" = x; then
>  fi
>  
>  # Obtain protocols headers include directives
> -PKG_CHECK_MODULES([X11], [xproto kbproto >= 1.0.5])
> +PKG_CHECK_MODULES([X11], [x11 xproto kbproto >= 1.0.5])


Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

You may want to ensure this is reviewed by one the authors of this lib.
I recall some readings putting emphasis on the fact that the library did
not
depend on libX11. 

This commit
http://cgit.freedesktop.org/xorg/lib/libxkbcommon/commit/?id=8d2c522f3156c3381d8530ce2346d1ec84fafe8d
says: "Don't check for xlib, we don't need it"

Maybe this include is not necessary or there is an alternate solution to
not depend on X11.



>  
>  # Obtain the path to the X Window System Core Protocol
>  AC_MSG_CHECKING([for X11 includedir])
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110129/cc3e8f81/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110129/cc3e8f81/attachment.pgp>