[PATCH v2 00/25] Various fixes based on static analysis - remaining patches

[Alan Coopersmith]

On 01/31/11 04:01 AM, Erkki Seppälä wrote:
> Here are the remaining patches of the libx11 static analysis batch
> that have not yet received feedback from the list. This batch has the
> comments fixed so that the actual change is first, while the diagnosis
> from the tool follows, thus making git shortlog more useful.

Though I would find git shortlog even more useful if the commits mentioned what
part of the code (module/function/file/etc.) they changed, so we didn't have
6 commits with basically the same description:

>       Removed unused assignment
>       Removed unused assignment
>       Zero-initialized new
>       Fixed by using strncpy and explicitly terminating the buffer
>       Fixed memory leak by adding Xfree
>       Fixed memory leak by adding Xfree and initializing missing_list with NULL
>       Fixed memory leak by adding Xfree
>       Fixed memory leak by adding Xfree
>       Fixed memory leak by adding Xfree
>       Fixed memory leak by adding Xfree
>       Instead of copying the value returned by get_prop_name and then releasing it, directly use the return value of g
>       The NEWTABLE macro missed freeing its allocated memory on subsequent memory allocation errors. Added call to Xfr
>       Fixed the handling of the extremely unlikely situation of fstat failing
>       Initialize local variable
>       Checked return value of XGetWindowProperty and return false if it fails.
>       Fixed by negative value to memcpy by checking for the negative return value of _Xlcwctomb and returning 0/XLooku
>       Removed superfluous check for NULL target_dir; it is already handled     before this code.
>       Removed superfluous check for NULL target_dir; it is already handled     before this code.

Also, looks like you have a few in that list that were too long for the line length.

If you haven't read it yet, you should probably check out
http://who-t.blogspot.com/2009/12/on-commit-messages.html

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System