[PATCH v2 09/25] [libx11] Fixed memory leak by adding Xfree

Alan Coopersmith alan.coopersmith at oracle.com
Mon Jan 31 23:21:41 PST 2011


On 01/31/11 04:02 AM, Erkki Seppälä wrote:
> Variable "colormap_ret" goes out of scope
> 
> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
> Signed-off-by: Erkki Seppälä <erkki.seppala at vincit.fi>
> ---
>  modules/im/ximcp/imRm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
> index 2e2c31f..fa86979 100644
> --- a/modules/im/ximcp/imRm.c
> +++ b/modules/im/ximcp/imRm.c
> @@ -2841,6 +2841,8 @@ _XimEncodeLocalStatusValue(
>  				ic->core.focus_window, &colormap_ret,
>  				&count, (Atom)p->value)))
>  	    return False;
> +
> +	Xfree(colormap_ret);
>      }
>      return True;
>  }

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list