[PATCH] xclipboard: avoid overflow crash when building labels

[Kees Cook]

Hi,

On Fri, Jul 08, 2011 at 08:34:48PM +0200, Julien Cristau wrote:
> On Fri, Jul  8, 2011 at 11:01:45 -0700, Kees Cook wrote:
> > This replaces sprintf with snprintf to avoid crashing when creating
> > various labels.
> > 
> > https://bugs.launchpad.net/ubuntu/+source/x11-apps/+bug/792642
> > 
> > Signed-off-by: Kees Cook <kees.cook at canonical.com>
> > ---
> >  xclipboard.c |    3 ++-
> >  xcutsel.c    |    4 ++--
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> asprintf or XtAsprintf maybe?

I've been told in the past not use asprintf because it isn't portable,
and I do not find XtAsprintf in the include files:

../xclipboard/xclipboard.c:337:2: warning: implicit declaration of function ‘XtAsprintf’
...
../xclipboard/xclipboard.c:337: undefined reference to `XtAsprintf'
collect2: ld returned 1 exit status

etc

I'm not sure how I should proceed. :P

Thanks,

-Kees

-- 
Kees Cook
Ubuntu Security Team