[PATCH 1.10] "privates.h", line 198: warning: void function cannot return value

[Jeremy Huddleston]

Yep.  Looks like it.

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>

On Jun 2, 2011, at 3:32 AM, Nicolas Kaiser wrote:

> * Alan Coopersmith <alan.coopersmith at oracle.com>:
>> Providing an argument to return in a function with void return type
>> is not allowed by the C standard, and makes the Sun compilers unhappy.
>> (They actually flag it as an error, unless using a new enough version
>> to be able to downgrade it to a warning with "-features=extensions".)
> 
> Out of curiosity, would the below function have the same problem?
> It looks to me pretty much identical in this respect.
> 
> Best regards,
> Nicolas Kaiser
> ---
> Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
> ---
> randr/rrcrtc.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c
> index d4d8f2a..0437795 100644
> --- a/randr/rrcrtc.c
> +++ b/randr/rrcrtc.c
> @@ -632,7 +632,7 @@ RRModeGetScanoutSize (RRModePtr mode, PictTransformPtr transform,
> void
> RRCrtcGetScanoutSize(RRCrtcPtr crtc, int *width, int *height)
> {
> -    return RRModeGetScanoutSize (crtc->mode, &crtc->transform, width, height);
> +    RRModeGetScanoutSize (crtc->mode, &crtc->transform, width, height);
> }
> 
> /*
> -- 
> 1.7.5.rc3
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>