Coping with -Wunused-but-set-variable, second round, v2
Cyril Brulebois
kibi at debian.org
Thu Jun 2 17:59:42 PDT 2011
Using Jeremy's summary:
-----------------------
1,2:
Ditto Alan's Response
→ New checks, both patches should probably be merged accordingly. Will
probably do once they get reviewed, for the pull request.
3,4:
Duplicates
→ Dropped.
6:
Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
5,6:
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
7,8,9:
Disgusted-by: Jeremy Huddleston <jeremyhu at apple.com>
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
10:
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
12:
Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
→ Amended with the tags, no further changes.
11:
I'd rather remove them than mark them unused
→ I did so, trying to keep diff noise low.
13,14:
Why not just remove the dead code or move the declaration into the #if 0?
→ Dropped for now, will probably be moved into the first series I
would have to investigate anyway (why are variables unused etc.).
Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110603/1f20747b/attachment.pgp>
More information about the xorg-devel
mailing list