[PATCH] xf86AutoConfig: Try newport on mips.

Daniel Stone daniel at fooishbar.org
Fri Jun 3 09:10:35 PDT 2011


On Fri, Jun 03, 2011 at 06:04:03PM +0200, Mark Kettenis wrote:
> > Since it just works for Bernhard, since you already have
> > platform-specific tricks, and since Matt has r-b'd this patch, I think
> > I'll just go ahead and include it in my pull request, and leave it up
> > to you folks to push your changes. Unless you have a last-minute
> > objection?
> 
> Sorry, but my objection still stands.  Please restrict that change to
> only affect Linux as I suggested, or drop it altogether.

We already have enough #ifdef RANDOM_OS conditionals as it is that, to
be blunt, make no fucking sense[0].  Can we please stop adding them?

If there's a problem in the autodetection code, we should be trying to
fix the problem, or at least enumerate the actual problem beyond
grumbling about all-the-world-is-PCI and subsequently papering over it
with an #ifdef that makes no sense today and will make even less sense
in a couple of years.

Cheers,
Daniel

[0]: My favourite was the sadly departed #ifdef MetroLink continue;
     #else return; #endif somewhere deep in XKB.


More information about the xorg-devel mailing list