Coping with -Wunused-but-set-variable, second round, v2
Jeremy Huddleston
jeremyhu at apple.com
Fri Jun 3 20:45:20 PDT 2011
LOL. You don't actually need to include my Disgusted-by tag ;) That was more just me wanting to express the my urge to vomit at the mess of macro-foo we put up with in some areas of the codebase
On Jun 2, 2011, at 8:59 PM, Cyril Brulebois wrote:
> Using Jeremy's summary:
> -----------------------
>
> 1,2:
> Ditto Alan's Response
>
> → New checks, both patches should probably be merged accordingly. Will
> probably do once they get reviewed, for the pull request.
>
>
> 3,4:
> Duplicates
>
> → Dropped.
>
>
> 6:
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> 5,6:
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 7,8,9:
> Disgusted-by: Jeremy Huddleston <jeremyhu at apple.com>
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 10:
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 12:
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
>
> → Amended with the tags, no further changes.
>
>
> 11:
> I'd rather remove them than mark them unused
>
> → I did so, trying to keep diff noise low.
>
>
> 13,14:
> Why not just remove the dead code or move the declaration into the #if 0?
>
> → Dropped for now, will probably be moved into the first series I
> would have to investigate anyway (why are variables unused etc.).
>
> Mraw,
> KiBi.
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
More information about the xorg-devel
mailing list