[PATCH 2/4] Remove the cacheing of the last scratch PixmapRec

[Keith Packard]

On Mon,  6 Jun 2011 06:36:07 +0100, Chris Wilson <chris at chris-wilson.co.uk> wrote:

> In order for the driver to be notified of when the resource backing the
> scratch pixmap becomes no longer accessible, it needs to be called on
> every FreeScratchPixmapHeader(). As we instead maybe cached the
> PixmapRec (to avoid the free and malloc overhead), this notification
> went astray, and the driver would fail to insert the correct barriers on
> the backing resource. That resource would then be reused by the Xserver,
> leading to rampant memory corruption as the GPU flushed it write caches
> at some point in the future and overwriting random structures.

This looks like a good thing to fix, and I'd like to get something into
1.11 if possible, but I'd rather not change this much code post RC1. Is
there a simpler fix you can think of for 1.11 while we pend the more
invasive change for 1.12?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110605/50284da1/attachment.pgp>