[PATCH 2/3] xkb: Fix case checks for Latin 2.

Daniel Stone daniel at fooishbar.org
Mon Jun 6 07:33:09 PDT 2011


Hi,

On Mon, Jun 06, 2011 at 04:25:26PM +0200, Cyril Brulebois wrote:
> Daniel Stone <daniel at fooishbar.org> (06/06/2011):
> > On Sun, Jun 05, 2011 at 03:27:08AM +0200, Cyril Brulebois wrote:
> > > Those ones were getting _XkbKSLower for no reasons:
> > >   XK_ogonek: U+02DB OGONEK
> > >   XK_doubleacute: U+02DD DOUBLE ACUTE ACCENT
> > 
> > I think this one also needs a check to exclude XK_breve.
> 
> keysymdef.h has:
> | #define XK_Aogonek                       0x01a1  /* U+0104 LATIN CAPITAL LETTER A WITH OGONEK */
> | #define XK_breve                         0x01a2  /* U+02D8 BREVE */
> | #define XK_Lstroke                       0x01a3  /* U+0141 LATIN CAPITAL LETTER L WITH STROKE */
> 
> xkbfmisc.c has:
> | 	case 1:		/* latin 2 */
> | 	    if (((ks>=XK_Aogonek)&&(ks<=XK_Zabovedot)&&(ks!=XK_breve))||
> | 		((ks>=XK_Racute)&&(ks<=XK_Tcedilla))) {
> | 		rtrn|= _XkbKSUpper;
> | 	    }
> 
> So I think it's covered already?

Shit, imagine I'm actually literate.  You're right. :)

Cheers,
Daniel


More information about the xorg-devel mailing list