[PATCH xf86-video-mga 0/9] Silence compile warnings and remove redundant defines

Alan Coopersmith alan.coopersmith at oracle.com
Wed Jun 8 13:10:02 PDT 2011


On 06/ 8/11 01:57 AM, Nicolas Kaiser wrote:
> These patches silence compile warnings, and remove some
> unused or duplicated defines.
> Tested on a Matrox G550 AGP.
> 
> [PATCH 1/9] include unistd.h for usleep()
> [PATCH 2/9] fix formats in xf86DrvMsg()
> [PATCH 3/9] hide conditionally used variable in mga_read_and_process_bios
> [PATCH 4/9] remove unused variables in MGAG200EHPIXPLLSET
> [PATCH 5/9] remove unused variables in CopyMungedScanlineFilterDown_AXP
> [PATCH 6/9] hide conditionally used variable in MGACopyILOAD
> [PATCH 7/9] maven: remove duplicated defines
> [PATCH 8/9] storm: remove unused define PSZ
> [PATCH 9/9] include xf86Modes.h for xf86ModeBandwidth()
> 
> Patch 1 and 9 additionally silence Gentoo QA warnings when
> compiling as Gentoo ebuild:
> 
> * QA Notice: Package has poor programming practices which may compile
> *            fine but exhibit random runtime failures.
> (..)
> * Please do not file a Gentoo bug and instead report the above QA
> * issues directly to the upstream developers of this software.
> * Homepage: http://xorg.freedesktop.org/
> 
> 
>  src/mga_bios.c   |    2 +-
>  src/mga_dacG.c   |    6 +-----
>  src/mga_driver.c |    1 +
>  src/mga_exa.c    |    2 +-
>  src/mga_maven.h  |    3 ---
>  src/mga_storm.c  |    2 --
>  src/mga_vga.c    |    2 ++
>  src/mga_video.c  |    6 ++++--
>  8 files changed, 10 insertions(+), 14 deletions(-)

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list