[PATCH:xkbcomp] Replace repeated checks for gcc with _X_ATTRIBUTE_PRINTF from xproto
Daniel Stone
daniel at fooishbar.org
Thu Jun 9 05:42:53 PDT 2011
Hi,
On Wed, Jun 08, 2011 at 05:52:08PM -0700, Alan Coopersmith wrote:
> On 06/ 8/11 01:06 AM, Mark Kettenis wrote:
> > Strangely formatted code, but that's not your fault.
>
> Yeah, xkbcomp's utils.h is rather messy all around - but as I looked
> at cleaning it up I saw so many things that needed fixing, I just
> punted for now. It could use reformatting and dropping unused macros
> (it defines 1-10 argument variants of each macro from the days before
> varargs macros, but many of those variants are never used).
Yeah, it's kind of unpleasant, but I'm pretty sure it was cut-and-wasted
all throughout lib/, so if you felt like cleaning it up, there are a lot
of other targets, too. :)
Anyway, if you wanted to drop the non-variadic macros, I think that'd be
entirely reasonable given that the server already requires variadic
macro support.
Cheers,
Daniel
More information about the xorg-devel
mailing list